Create core project with non-jvm-only dependencies#35
Open
johnynek wants to merge 6 commits intouuverifiers:masterfrom
Open
Create core project with non-jvm-only dependencies#35johnynek wants to merge 6 commits intouuverifiers:masterfrom
johnynek wants to merge 6 commits intouuverifiers:masterfrom
Conversation
This reverts commit 246d7a9.
johnynek
commented
Feb 22, 2026
| comp | ||
|
|
||
| } else { | ||
|
|
Author
There was a problem hiding this comment.
obviously this changes semantics, but if we were to pursue this we could implement a version of this file for the JVM and one for scala JS and implement the intent correctly.
johnynek
commented
Feb 22, 2026
| class CounterState { | ||
|
|
||
| private val counters = new ConcurrentHashMap[Counter, LongAdder] | ||
| private val counters = new MHashMap[Counter, Long] { |
Author
There was a problem hiding this comment.
obviously this isn't safe in a threaded environment, but if the approach is interesting to you we could implement a jvm version of this file and js version of this file and select the correct one at build time.
Collaborator
|
This looks like a reasonable approach! Two thoughts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to be able to run princess on scalajs (see issue #34 ).
This PR attempts to move all non-JVM code into a core package, leaving the current APIs that require the JVM in the src directory.
I don't think this is ready to merge, but it is here to see if you are open to a refactor along these lines.